Use domain.bind to preserve domain context #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a case of the userland queueing problem. We don't have automatic implicit binding here, so we need to do explicit binding, as described in the domain docs.
I'm aware that domains are deprecated, people should avoid using them, a replacement is coming, etc, but there are use cases where they are absolutely necessary and losing the domain context can lead to state mismatches. This fix will be helpful for any projects that use node-pool (or anything depending on node-pool) and any sort of domain context pattern (or any of several error reporting and APM tools which do).
For reference, the widely-used redis, cassandra, mysql, and postgres drivers handle this correctly, among others.